Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clear all on ChipSelect #832

Merged
merged 5 commits into from
Dec 9, 2024
Merged

feat: add clear all on ChipSelect #832

merged 5 commits into from
Dec 9, 2024

Conversation

gca-axelor
Copy link
Contributor

@gca-axelor gca-axelor commented Dec 6, 2024 •
edited
Loading

RM#87395

@gca-axelor gca-axelor added 🌟 Feature New feature ✅ Done Development done, awaiting feedback labels Dec 6, 2024
vhu-axelor
vhu-axelor reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@vhu-axelor vhu-axelor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update story and test files

packages/ui/src/components/organisms/ChipSelect/ChipSelect.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/organisms/ChipSelect/ChipSelect.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/organisms/ChipSelect/ChipSelect.tsx Outdated Show resolved Hide resolved
packages/ui/src/components/organisms/ChipSelect/ChipSelect.tsx Outdated Show resolved Hide resolved
@vhu-axelor vhu-axelor assigned gca-axelor and unassigned vhu-axelor Dec 9, 2024
@vhu-axelor vhu-axelor added 🪃 Feedback Feedback given by maintainer and removed ✅ Done Development done, awaiting feedback labels Dec 9, 2024
@gca-axelor gca-axelor assigned vhu-axelor and unassigned gca-axelor Dec 9, 2024
@gca-axelor gca-axelor added ✅ Done Development done, awaiting feedback and removed 🪃 Feedback Feedback given by maintainer labels Dec 9, 2024
@vhu-axelor vhu-axelor assigned lme-axelor and unassigned vhu-axelor Dec 9, 2024
@vhu-axelor vhu-axelor added the Pair approved 🌟 Pair approved changes label Dec 9, 2024
@lme-axelor lme-axelor added the Approved 🌟 Can be merged after pipeline succeed label Dec 9, 2024
@lme-axelor lme-axelor merged commit 71b5f49 into axelor:wip Dec 9, 2024
4 checks passed
lme-axelor pushed a commit that referenced this pull request Dec 10, 2024
@gca-axelor @lme-axelor
feat: add clear all on ChipSelect (#832)
6dac2fb 
* RM#87395
lme-axelor pushed a commit that referenced this pull request Dec 17, 2024
@gca-axelor @lme-axelor
feat: add clear all on ChipSelect (#832)
1f736ae 
* RM#87395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhu-axelor vhu-axelor vhu-axelor left review comments

Assignees

@lme-axelor lme-axelor

Labels
Approved 🌟 Can be merged after pipeline succeed ✅ Done Development done, awaiting feedback 🌟 Feature New feature Pair approved 🌟 Pair approved changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gca-axelor @vhu-axelor @lme-axelor