fix: reset all states in TimerListAlert and add refresh of timer list…

… view
axelor · Feb 9, 2024 · d63bf6a · d63bf6a
1 parent 327b0ba
commit d63bf6a
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 6 deletions.
diff --git a/packages/apps/hr/src/components/templates/DraftTimesheetPicker/DraftTimesheetPicker.tsx b/packages/apps/hr/src/components/templates/DraftTimesheetPicker/DraftTimesheetPicker.tsx
@@ -60,6 +60,10 @@ const DraftTimesheetPicker = ({
     )} - ${formatDate(item.toDate, I18n.t('Base_DateFormat'))}`;
   };
 
+  if (!Array.isArray(draftTimesheetList) || draftTimesheetList.length === 0) {
+    return null;
+  }
+
   return (
     <Picker
       style={style}

diff --git a/packages/apps/hr/src/components/templates/TimerListAlert/TimerListAlert.tsx b/packages/apps/hr/src/components/templates/TimerListAlert/TimerListAlert.tsx
@@ -123,7 +123,7 @@ const TimerListAlert = ({
     );
   };
 
-  const handleCancel = () => {
+  const resetStates = () => {
     setIsAlertVisible(false);
     setTimesheet(null);
     setFromDate(null);
@@ -152,7 +152,7 @@ const TimerListAlert = ({
         }),
       );
     }
-    setIsAlertVisible(false);
+    resetStates();
     navigation.navigate('TimesheetListScreen');
   };
 
@@ -162,7 +162,7 @@ const TimerListAlert = ({
       visible={isAlertVisible}
       title={I18n.t('Hr_SelectTimers')}
       cancelButtonConfig={{
-        onPress: handleCancel,
+        onPress: resetStates,
       }}
       confirmButtonConfig={{
         width: 50,

diff --git a/packages/apps/hr/src/features/timesheetSlice.js b/packages/apps/hr/src/features/timesheetSlice.js
@@ -31,6 +31,7 @@ import {
   fetchTimesheetToValidate as _fetchTimesheetToValidate,
   updateTimesheetStatus as _updateTimesheetStatus,
 } from '../api/timesheet-api';
+import {fetchTimer} from './timerSlice';
 
 export const fetchTimesheet = createAsyncThunk(
   'timesheet/fetchTimesheet',
@@ -93,9 +94,13 @@ export const createTimesheet = createAsyncThunk(
       action: 'Hr_SliceAction_CreateTimesheet',
       getState,
       responseOptions: {isArrayResponse: false},
-    }).then(() => {
-      dispatch(fetchTimesheet({userId: data.userId}));
-    });
+    })
+      .then(() => {
+        dispatch(fetchTimesheet({userId: data.userId}));
+      })
+      .then(() => {
+        dispatch(fetchTimer({userId: data.userId}));
+      });
   },
 );
 
@@ -108,6 +113,8 @@ export const addTimerTimesheet = createAsyncThunk(
       action: 'Hr_SliceAction_AddTimerTimesheet',
       getState,
       responseOptions: {isArrayResponse: false},
+    }).then(() => {
+      dispatch(fetchTimer({userId: data.userId}));
     });
   },
 );