fix: reduce number of calls for print action (#816)

RM#87597
axelor · Nov 28, 2024 · bfa318e · bfa318e
1 parent 9119db3
commit bfa318e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/changelogs/unreleased/87597.json b/changelogs/unreleased/87597.json
@@ -0,0 +1,5 @@
+{
+  "title": "Print header action: check if a template exists only when model and id are present",
+  "type": "fix",
+  "packages": "core"
+}
diff --git a/packages/core/src/header/hooks.js b/packages/core/src/header/hooks.js
@@ -107,11 +107,13 @@ export const useBasicActions = ({
   }, [model]);
 
   useEffect(() => {
-    fetchActionPrint({model, id: modelId})
-      .catch(() => setDisablePrinting(true))
-      .then(({templateSet, fileName}) => {
-        setDisablePrinting(templateSet == null && fileName == null);
-      });
+    if (model && modelId) {
+      fetchActionPrint({model, id: modelId})
+        .catch(() => setDisablePrinting(true))
+        .then(({templateSet, fileName}) => {
+          setDisablePrinting(templateSet == null && fileName == null);
+        });
+    }
   }, [model, modelId]);
 
   const checkInternetConnection = useCallback(async () => {