fix: add scrollview style to enable scrollview (#662)

* RM#80721
axelor · Aug 2, 2024 · b5a6bf1 · b5a6bf1
1 parent a57ebf2
commit b5a6bf1
Show file tree

Hide file tree

Showing 6 changed files with 55 additions and 5 deletions.
diff --git a/changelogs/unreleased/80721.json b/changelogs/unreleased/80721.json
@@ -0,0 +1,5 @@
+{
+  "title": "Details screens: manage scroll style for small screens",
+  "type": "fix",
+  "packages": "crm"
+}
diff --git a/packages/apps/crm/src/screens/client/ClientDetailsScreen.js b/packages/apps/crm/src/screens/client/ClientDetailsScreen.js
@@ -17,6 +17,7 @@
  */
 
 import React, {useCallback, useEffect} from 'react';
+import {StyleSheet} from 'react-native';
 import {
   Screen,
   HeaderContainer,
@@ -61,7 +62,9 @@ const ClientDetailsScreen = ({route}) => {
   return (
     <Screen removeSpaceOnTop={true}>
       <HeaderContainer expandableFilter={false} fixedItems={<ClientHeader />} />
-      <ScrollView refresh={{loadingClient, fetcher: getClient}}>
+      <ScrollView
+        refresh={{loadingClient, fetcher: getClient}}
+        style={styles.scrollView}>
         <NotesCard title={I18n.t('Crm_Notes')} data={client.description} />
         <ClientDropdownCards />
       </ScrollView>
@@ -70,4 +73,10 @@ const ClientDetailsScreen = ({route}) => {
   );
 };
 
+const styles = StyleSheet.create({
+  scrollView: {
+    height: null,
+  },
+});
+
 export default ClientDetailsScreen;
diff --git a/packages/apps/crm/src/screens/contact/ContactDetailsScreen.js b/packages/apps/crm/src/screens/contact/ContactDetailsScreen.js
@@ -17,6 +17,7 @@
  */
 
 import React, {useCallback, useEffect} from 'react';
+import {StyleSheet} from 'react-native';
 import {
   Screen,
   HeaderContainer,
@@ -65,7 +66,9 @@ const ContactDetailsScreen = ({route}) => {
         expandableFilter={false}
         fixedItems={<ContactHeader />}
       />
-      <ScrollView refresh={{loading, fetcher: getContactAPI}}>
+      <ScrollView
+        refresh={{loading, fetcher: getContactAPI}}
+        style={styles.scrollView}>
         <ContactPartnerCard />
         <NotesCard title={I18n.t('Crm_Notes')} data={contact.description} />
         <ContactDropdownCards />
@@ -75,4 +78,10 @@ const ContactDetailsScreen = ({route}) => {
   );
 };
 
+const styles = StyleSheet.create({
+  scrollView: {
+    height: null,
+  },
+});
+
 export default ContactDetailsScreen;
diff --git a/packages/apps/crm/src/screens/lead/LeadDetailsScreen.js b/packages/apps/crm/src/screens/lead/LeadDetailsScreen.js
@@ -17,6 +17,7 @@
  */
 
 import React, {useCallback, useEffect} from 'react';
+import {StyleSheet} from 'react-native';
 import {
   Screen,
   HeaderContainer,
@@ -60,7 +61,9 @@ const LeadDetailsScreen = ({route}) => {
         expandableFilter={false}
         fixedItems={<LeadHeader idLead={idLead} versionLead={versionLead} />}
       />
-      <ScrollView refresh={{loading: loadingLead, fetcher: getLead}}>
+      <ScrollView
+        refresh={{loading: loadingLead, fetcher: getLead}}
+        style={styles.scrollView}>
         <NotesCard title={I18n.t('Crm_Description')} data={lead.description} />
         <LeadDropdownCards />
       </ScrollView>
@@ -69,4 +72,10 @@ const LeadDetailsScreen = ({route}) => {
   );
 };
 
+const styles = StyleSheet.create({
+  scrollView: {
+    height: null,
+  },
+});
+
 export default LeadDetailsScreen;
diff --git a/packages/apps/crm/src/screens/opportunity/OpportunityDetailsScreen.js b/packages/apps/crm/src/screens/opportunity/OpportunityDetailsScreen.js
@@ -17,6 +17,7 @@
  */
 
 import React, {useCallback, useEffect} from 'react';
+import {StyleSheet} from 'react-native';
 import {
   Screen,
   HeaderContainer,
@@ -65,7 +66,8 @@ const OpportunityDetailsScreen = ({route}) => {
         fixedItems={<OpportunityHeader />}
       />
       <ScrollView
-        refresh={{loading: loadingOpportunity, fetcher: getOpportunityAPI}}>
+        refresh={{loading: loadingOpportunity, fetcher: getOpportunityAPI}}
+        style={styles.scrollView}>
         <OpportunityPartnerCard />
         <OpportunityDropdownInfo />
         <NotesCard
@@ -79,4 +81,10 @@ const OpportunityDetailsScreen = ({route}) => {
   );
 };
 
+const styles = StyleSheet.create({
+  scrollView: {
+    height: null,
+  },
+});
+
 export default OpportunityDetailsScreen;
diff --git a/packages/apps/crm/src/screens/prospect/ProspectDetailsScreen.js b/packages/apps/crm/src/screens/prospect/ProspectDetailsScreen.js
@@ -17,6 +17,8 @@
  */
 
 import React, {useCallback, useEffect} from 'react';
+import {StyleSheet} from 'react-native';
+
 import {
   Screen,
   HeaderContainer,
@@ -64,7 +66,9 @@ const ProspectDetailsScreen = ({route}) => {
         expandableFilter={false}
         fixedItems={<ProspectHeader />}
       />
-      <ScrollView refresh={{loading, fetcher: getProspect}}>
+      <ScrollView
+        refresh={{loading, fetcher: getProspect}}
+        style={styles.scrollView}>
         <NotesCard title={I18n.t('Crm_Notes')} data={prospect.description} />
         <ProspectDropdownCards />
       </ScrollView>
@@ -73,4 +77,10 @@ const ProspectDetailsScreen = ({route}) => {
   );
 };
 
+const styles = StyleSheet.create({
+  scrollView: {
+    height: null,
+  },
+});
+
 export default ProspectDetailsScreen;