Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: do not add "/" before %{_libdir} #954

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Sep 28, 2023

%{_libdir} is always an absolute path, so there is no need to prefix it with "/". in general, it does not hurt. but this extra slash would be written into .pc file, so the generated .pc file would look like:

libdir=//usr/lib64

which is not quite perfect. so let's drop the heading "/".


git request-pull output:

The following changes since commit b58921e0b0ae84b6f1cd22b87c66a6e91a540ec8:

  Merge branch 'uring_sysctl' of https://github.com/matrizzo/liburing (2023-09-13 08:11:53 -0600)

are available in the Git repository at:

  [email protected]:tchaikov/liburing.git remove-dup-slash

for you to fetch changes up to be96a8fcba45ea6d8d23239d7cb9e2a62651c354:

  spec: do not add "/" before %{_libdir} (2023-09-28 12:57:58 +0800)

----------------------------------------------------------------
Kefu Chai (1):
      spec: do not add "/" before %{_libdir}

 liburing.spec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <[email protected]>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <[email protected]>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

%{_libdir} is always an absolute path, so there is no need to prefix
it with "/". in general, it does not hurt. but this extra slash would
be written into .pc file, so the generated .pc file would look like:

```
libdir=//usr/lib64
```

which is not quite perfect. so let's drop the heading "/".

Signed-off-by: Kefu Chai <[email protected]>
@axboe axboe merged commit b3ee3e7 into axboe:master Sep 28, 2023
13 checks passed
@tchaikov tchaikov deleted the remove-dup-slash branch September 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants