Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] man/prep_openat{2}: clarify IOSQE_FIXED_FILE #1254

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

aconz2
Copy link
Contributor

@aconz2 aconz2 commented Oct 2, 2024

  • minor rearrangement & split of pargraph
  • clarify that IOSQE_FIXED_FILE is for subsequent sqe, not this one
  • note that dfd is always a regular file descriptor

git request-pull output:

The following changes since commit 352c8ab127e1924d64fbbd2bf337c06d1c1abd03:

  examples/kdigest: misc updates and improvements (2024-10-01 16:44:35 -0600)

are available in the Git repository at:

  https://github.com/aconz2/liburing man-open2

for you to fetch changes up to d7c02c9a396cfba5cfa9ffe9b113cb7428096766:

  man/prep_openat{2}: clarify IOSQE_FIXED_FILE (2024-10-02 11:59:29 -0500)

----------------------------------------------------------------
Andrew Consroe (1):
      man/prep_openat{2}: clarify IOSQE_FIXED_FILE

 man/io_uring_prep_openat.3  | 41 +++++++++++++++++++++++------------------
 man/io_uring_prep_openat2.3 | 46 ++++++++++++++++++++++++++--------------------
 2 files changed, 49 insertions(+), 38 deletions(-)

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <[email protected]>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <[email protected]>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

minor rearrangement & split of pargraph
clarify that IOSQE_FIXED_FILE is for subsequent sqe, not this one
note that dfd is always a regular file descriptor

Signed-off-by: Andrew Consroe <[email protected]>
@axboe
Copy link
Owner

axboe commented Oct 2, 2024

Thanks reads much better, thanks!

@axboe axboe merged commit 9d5adc5 into axboe:master Oct 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants