Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIT PULL] Liburing/prep_helpers: Add Open helpers #1248

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

CPestka
Copy link
Contributor

@CPestka CPestka commented Sep 29, 2024

Adds the direct and regular open prep helper as two small wrapper functions around the openat prep helper.
Also adds the links for them in the man pages.
Would close #1100


git request-pull output:

The following changes since commit 206650ff72b6ea4d76921f9c91ebfffd9902e6a0:

  test/fixed-hugepage: skip test on -ENOMEM (2024-09-27 10:27:10 -0600)

are available in the Git repository at:

  https://github.com/CPestka/liburing open_helper

for you to fetch changes up to 48ca808a97556e1d1e25d6b5f924c7881ca1f367:

  man/prep_open: Add man entry for io_uring_prep_open(_direct) (2024-09-29 13:27:55 +0200)

----------------------------------------------------------------
CPestka (2):
      liburing/sqe_helper: Add helper to prep sqe for an open
      man/prep_open: Add man entry for io_uring_prep_open(_direct)

 man/io_uring_prep_open.3        |  1 +
 man/io_uring_prep_open_direct.3 |  1 +
 man/io_uring_prep_openat.3      | 16 ++++++++++++++++
 src/include/liburing.h          | 14 ++++++++++++++
 src/liburing-ffi.map            |  2 ++
 5 files changed, 34 insertions(+)
 create mode 120000 man/io_uring_prep_open.3
 create mode 120000 man/io_uring_prep_open_direct.3

Click to show/hide pull request guidelines

Pull Request Guidelines

  1. To make everyone easily filter pull request from the email
    notification, use [GIT PULL] as a prefix in your PR title.
[GIT PULL] Your Pull Request Title
  1. Follow the commit message format rules below.
  2. Follow the Linux kernel coding style (see: https://github.com/torvalds/linux/blob/master/Documentation/process/coding-style.rst).

Commit message format rules:

  1. The first line is title (don't be more than 72 chars if possible).
  2. Then an empty line.
  3. Then a description (may be omitted for truly trivial changes).
  4. Then an empty line again (if it has a description).
  5. Then a Signed-off-by tag with your real name and email. For example:
Signed-off-by: Foo Bar <[email protected]>

The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).

Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.

Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.

If the commit is a fix for an issue, add a Fixes tag with the issue
URL.

Don't use GitHub anonymous email like this as the commit author:

Use a real email address!

Commit message example:

src/queue: don't flush SQ ring for new wait interface

If we have IORING_FEAT_EXT_ARG, then timeouts are done through the
syscall instead of by posting an internal timeout. This was done
to be both more efficient, but also to enable multi-threaded use
the wait side. If we touch the SQ state by flushing it, that isn't
safe without synchronization.

Fixes: https://github.com/axboe/liburing/issues/402
Signed-off-by: Jens Axboe <[email protected]>

By submitting this pull request, I acknowledge that:

  1. I have followed the above pull request guidelines.
  2. I have the rights to submit this work under the same license.
  3. I agree to a Developer Certificate of Origin (see https://developercertificate.org for more information).

Adds a prep helper for open and open with direct fd on top of the
existing openat helpers.

Signed-off-by: Constantin Pestka <[email protected]>
@axboe
Copy link
Owner

axboe commented Sep 29, 2024

Makes sense to add, thanks.

@axboe axboe merged commit 3ca941c into axboe:master Sep 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: io_uring_prep_open
2 participants