Fix Proptest inflight_write invalidation after PutObject to same element #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
changed the title
c-hagem
force-pushed
the
reftest-staleness-failure
branch
from
1dfe711 to
04d5a73
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
force-pushed
the
reftest-staleness-failure
branch
from
04d5a73 to
2bf9c74
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
changed the title
c-hagem
force-pushed
the
reftest-staleness-failure
branch
from
2bf9c74 to
fc69723
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
force-pushed
the
reftest-staleness-failure
branch
from
fc69723 to
beeede8
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
reviewed
Jan 15, 2025
There was a problem hiding this comment.
I don't know if this quite represents what we want.
If the file has been created (mknod) and opened for writing (open), it should be possible to write to that file and upload the object even though it would then not be visible in the file system after. Moreover, the end state of the file system should mean that remotely in S3 we should see the file even though it will not be visible in Mountpoint.
We need to somehow tolerate the open returning ESTALE - maybe we can discuss in-person how feasible that might be.
| @@ -47,6 +47,7 @@ time = { version = "0.3.37", features = ["macros", "formatting"] } | |||
| tracing = { version = "0.1.41", features = ["log"] } | |||
| tracing-log = "0.2.0" | |||
| tracing-subscriber = { version = "0.3.19", features = ["env-filter"] } | |||
| log = "0.4.22" | |||
There was a problem hiding this comment.
We shouldn't need this
Adds a failing proptest, which occured as we did not remove inflight writes to a file, if it was overriden by a PutObject. Fixes this by invalidating such writes. Signed-off-by: Christian Hagemeier <[email protected]>
c-hagem
force-pushed
the
reftest-staleness-failure
branch
from
beeede8 to
b654a0d
Compare
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
c-hagem
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a failing proptest, and a potential fix for it. The root cause seems to have been that if after a file has been opened, and then modified by i.e., a remote PutObject, the old ino is stale, but will be opened in the inflight-write regardless.
This code change fixes this issue by removing such a inflight write. For reviewers:
invalidatemethod to invalidate based on a PathBuf)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).