Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use observation mask as feature in DeepAR #2892

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

abdulfatir
Copy link
Contributor

Description of changes:
This PR adds the observation mask as an input feature to DeepAR. Previously lags were fed into the model but the model had no information on whether the lag value is observed or missing/padded.

I ran a small experiment to gauge the performance with and without (previous version) the mask feature. Here are the results on the solar dataset averaged over 10 runs. Each model was trained for 10 epochs.

model NRMSE ND mean_wQuantileLoss sMAPE MASE
with_mask (now) 1.0553 0.4896 0.4054 1.3745 1.1503
without_mask (previous) 1.0551 0.4892 0.4074 1.3741 1.1495

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella
Copy link
Contributor

Here are the results on the solar dataset averaged over 10 runs.

Does the dataset contain missing values?

@lostella lostella added BREAKING This is a breaking change (one of pr required labels) enhancement New feature or request labels May 27, 2023
@abdulfatir
Copy link
Contributor Author

No, it does not, so this only testing the padding aspect.

@lostella lostella added the torch This concerns the PyTorch side of GluonTS label May 31, 2023
@lostella lostella added the models This item concerns models implementations label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING This is a breaking change (one of pr required labels) enhancement New feature or request models This item concerns models implementations torch This concerns the PyTorch side of GluonTS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants