Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add e2e tests to PR workflow #11

Merged
merged 3 commits into from
Mar 16, 2024
Merged

chore: Add e2e tests to PR workflow #11

merged 3 commits into from
Mar 16, 2024

Conversation

niallthomson
Copy link
Contributor

@niallthomson niallthomson commented Mar 16, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Better assess regressions caused by changes by running as much of the Backstage application as possible

Description of changes

Additional workflow step that runs the Backstage application then executes the Playwright test suite.

Also removed conventional commit precommit check since its unnecessary due to workflow checks.

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@niallthomson niallthomson requested a review from a team as a code owner March 16, 2024 03:50
@niallthomson niallthomson merged commit 8db5f04 into main Mar 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant