Restore request body after reading in sign method
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes awslabs#225 The problem is the the `sign` method in ProxyClient reads the `req.Body` and that results in a closed reader. When the request is actually send to the transport later, the body cannot be read and results in a body length of 0 which does not match the passed req.ContentLength. We tried to write tests for this, but the tests are not fully matching the real world because: * they use io.NopCloser * they use a HTTP mock client that doesn't actually read the body to send to the proxy (makes sense, its a mock, but it's different than the actual implementation)
|
@roystchiang @rapphil Could you please approve the workflow? If you have time, please advice how to write tests for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#225
Description of changes:
The problem is the the
signmethod in ProxyClient reads thereq.Bodyand that results in a closed reader.When the request is actually send to the transport later, the body cannot be read and results in a body length of 0 which does not match the passed req.ContentLength.
We tried to write tests for this, but the tests are not fully matching the real world because:
If you have advice how to test this properly, we're all ears.