Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make modeled errors Sendable #1846

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Make modeled errors Sendable #1846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a0ff8
chore: Make modeled errors Sendable
jbelkins Dec 10, 2024
83626ef
Merge branch 'main' into jbe/20241209_sendable
jbelkins Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...mazon/smithy/aws/swift/codegen/ec2query/Ec2QueryHttpResponseBindingErrorGeneratorTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ extension ComplexError {
val contents = TestUtils.getFileContents(context.manifest, "Sources/Example/models/ComplexError.swift")
contents.shouldSyntacticSanityCheck()
val expectedContents = """
public struct ComplexError: ClientRuntime.ModeledError, AWSClientRuntime.AWSServiceError, ClientRuntime.HTTPError, Swift.Error {
public struct ComplexError: ClientRuntime.ModeledError, AWSClientRuntime.AWSServiceError, ClientRuntime.HTTPError, Swift.Error, Swift.Sendable {

public struct Properties {
public struct Properties: Swift.Sendable {
public internal(set) var nested: EC2ProtocolClientTypes.ComplexNestedErrorData? = nil
public internal(set) var topLevel: Swift.String? = nil
}
Expand Down
4 changes: 2 additions & 2 deletions ...azon/smithy/aws/swift/codegen/restxml/AWSRestXMLHTTPResponseBindingErrorGeneratorTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ extension ComplexXMLError {
val contents = getFileContents(context.manifest, "/Sources/Example/models/ComplexXMLError.swift")
contents.shouldSyntacticSanityCheck()
val expectedContents = """
public struct ComplexXMLError: ClientRuntime.ModeledError, AWSClientRuntime.AWSServiceError, ClientRuntime.HTTPError, Swift.Error {
public struct ComplexXMLError: ClientRuntime.ModeledError, AWSClientRuntime.AWSServiceError, ClientRuntime.HTTPError, Swift.Error, Swift.Sendable {

public struct Properties {
public struct Properties: Swift.Sendable {
public internal(set) var header: Swift.String? = nil
public internal(set) var nested: RestXmlerrorsClientTypes.ComplexXMLNestedErrorData? = nil
public internal(set) var topLevel: Swift.String? = nil
Expand Down
Loading