Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Account ID-based endpoints #1841

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat: Account ID-based endpoints #1841

wants to merge 15 commits into from

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Dec 6, 2024

Description of changes

  • The AWS-specific EndpointResolverMiddleware is renamed to AWSEndpointResolverMiddleware to make clear that it is an AWS-specialized type
  • AWSEndpointResolverMiddleware is protected with Swift @_spi() to conceal it from public usage.
  • Endpoint params are now created by a block which can be passed into the middleware for inline evaluation, since account ID may not be known yet when endpoint params are currently constructed.
  • accountId is no longer exposed as a client config param since it is set only via AWS credential identity resolvers
  • Update to aws-crt-swift 0.41.0 with support for account ID in AWS credentials

Note: Bump minor version when this feature ships

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant