-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose presign / presignURL methods in Models.swift to service client object #1198
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
154c778
Add codegen to expose presign / presignURL methods on service client …
75f363b
Resolve PR comments.
54b01c6
Make presign to return URLRequest.
81d8d71
Add special-case import statement for FoundationNetworking if OS is l…
bba921e
Merge branch 'main' into feat/expose-presigning-in-client
f70194a
Merge branch 'main' into feat/expose-presigning-in-client
f219fe8
Resolve PR comments.
a83158e
Change conversion method from toURLRequest to using extension constru…
1b259d5
Add documentation for generated presign API.
3bc0c8d
Update documentation & method names for presigner APIs.
57f5e39
Merge branch 'main' into feat/expose-presigning-in-client
sichanyoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comment should include the same docs that are rendered onto the regular operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean by this - do you mean the links to AWS docs (the ones in Smithy model under documentation trait)? If so, they aren't available for these presign operations because these are added at SDK level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline - will add docs as mentioned.