Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Fix tests related to output struct rename #1170

Merged
merged 2 commits into from
Oct 7, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Oct 4, 2023

Issue #

#1169

Description of changes

The companion to this PR smithy-lang/smithy-swift#599 changes the name suffix of operation output structures from OutputResponse to just Output.

This PR just fixes codegen tests affected by this name change.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins requested a review from sichanyoo October 5, 2023 16:42
@jbelkins jbelkins assigned dayaffe and jbelkins and unassigned dayaffe Oct 5, 2023
@jbelkins jbelkins requested a review from dayaffe October 5, 2023 16:42
Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jbelkins jbelkins merged commit 0c97886 into main Oct 7, 2023
10 checks passed
@jbelkins jbelkins deleted the jbe/operation_output_rename branch October 7, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants