Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct serde for restJson1 event streams that contain errors #1160

Merged
merged 7 commits into from
Oct 2, 2023

Conversation

jbelkins
Copy link
Contributor

Issue #

#1159

Description of changes

Fixes the following two compile errors that affect event streams on the restJson1 protocol, which were discovered with the launch of the AWS Bedrock service.

  • Corrects the serializer for an error received via an event stream to use the properties namespace.
  • Corrects the message unmarshaller to use the correct type when unmarshalling an error from a data stream.

Note: this PR includes the model definitions for the Bedrock service, so the model can be codegen'd & built/tested on CI.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins
Copy link
Contributor Author

/test

Copy link
Contributor

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any tests we should or can add around this change?

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jbelkins
Copy link
Contributor Author

jbelkins commented Oct 2, 2023

/test

@jbelkins jbelkins merged commit c0fa0e4 into main Oct 2, 2023
10 checks passed
@jbelkins jbelkins deleted the jbe/bedrock_streaming_fix branch October 2, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants