Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Smithy 1.39.0 #1126

Merged
merged 14 commits into from
Sep 26, 2023
Merged

chore: Update to Smithy 1.39.0 #1126

merged 14 commits into from
Sep 26, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Sep 14, 2023

Issue #

#1037

Description of changes

Updates the project for breaking changes to the endpoints rule engine in Smithy 1.39.0.

  • Update the name and/or location of several Smithy classes.
  • The Swift SDK codegen phase currently copies partitions.json out of the Smithy project for use when code-generating endpoint resolvers. This is not desirable because the copy in Smithy is infrequently updated. Eventually, partitions.json will be supplied at build time by the SDK release coordination system, but for now, an up-to-date copy is provided in this project, and will be updated when needed.
  • partitions.json is no longer rendered into every endpoint resolver since it is the same for every service client. Instead, one common copy is provided in AWSClientRuntime.
  • An unused endpoints.json file is deleted.

Protocol tests:

  • It was discovered that Smithy protocol tests for RestJSON were being run twice: once with Smithy tests & again with local tests. The second execution is omitted.
  • There are two new protocol tests that fail. They are disabled & tracked by separate tickets.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbelkins jbelkins requested a review from dayaffe September 20, 2023 15:10
Copy link
Contributor

@dayaffe dayaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jbelkins jbelkins changed the title chore: Adopt Smithy with Endpoints refactor chore: Update to Smithy 1.39.0 Sep 25, 2023
@jbelkins jbelkins merged commit fc076b7 into main Sep 26, 2023
10 checks passed
@jbelkins jbelkins deleted the jbe/endpoints_refactor branch September 26, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants