Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Smithy 1.37.0, disable selected protocol tests #1123

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Sep 13, 2023

Issue #

#1037 (this Smithy update is a prereq for this issue)

Description of changes

Update to Smithy 1.37.0.

  • To support selective exclusion of protocol tests, the AWSHttpBindingProtocolGenerator is provided with an overridable list of tests to be excluded at codegen time.
  • Disables selected protocol tests for not-yet-implemented Smithy features & service customizations:
    • All request compression tests, across all protocols
    • S3 S3EscapeObjectKeyInUriLabel and S3EscapePathObjectKeyInUriLabel
    • Re-enablement of these tests will be tracked in separate tickets.
  • Re-enables the kinesis-video-archived-media AWS service, which was disabled because of the need for a paginator validation change in Smithy 1.35.0.
  • Adjusts Gradle JVM memory usage to 4096 MB, to prevent spurious codegen failures due to exhausting heap space.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins
Copy link
Contributor Author

/test

Copy link
Contributor

@sichanyoo sichanyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbelkins jbelkins merged commit bbbe467 into main Sep 13, 2023
10 checks passed
@jbelkins jbelkins deleted the jbe/use_smithy_1_37_0 branch September 13, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants