Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows support in PlatformOperationSystemVersion #1526

Closed
sichanyoo opened this issue May 24, 2024 · 1 comment
Closed

Add Windows support in PlatformOperationSystemVersion #1526

sichanyoo opened this issue May 24, 2024 · 1 comment

Comments

@sichanyoo
Copy link
Contributor

Background

In smithy-swift, PlatformOperationSystemVersion gets OS versions for Linux and macOS. This OS version information gets included in OSMetadata segment of the user agent header.

To Do

Add support for Windows as well.

Other Info

Related issue: #1206
@sichanyoo sichanyoo added the needs-triage This issue or PR still needs to be triaged. label May 24, 2024
@sichanyoo sichanyoo mentioned this issue May 24, 2024
Closed
2 tasks
@sichanyoo
Copy link
Contributor Author

Turns out Apple recently implemented getting OS versions for Linux & Windows for us using compiler directives in their Foundation.ProcessInfo. Closing #1526.

@sichanyoo sichanyoo removed the needs-triage This issue or PR still needs to be triaged. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sichanyoo