Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add linux and windows support in PlatformOperationSystemVersion #1206

Closed
2 tasks
Tracked by #710
dayaffe opened this issue Oct 30, 2023 · 2 comments
Closed
2 tasks
Tracked by #710

feat: Add linux and windows support in PlatformOperationSystemVersion #1206

dayaffe opened this issue Oct 30, 2023 · 2 comments
Assignees
@sichanyoo
Labels
feature-request A feature should be added or improved.
Milestone
GA

Comments

@dayaffe
Copy link
Contributor

dayaffe commented Oct 30, 2023 •
edited
Loading

Describe the feature

For iOS, watchOS, macOS, and tvOS we currently support the ability to determine the major, minor, and patch versions. For all other operating systems we return nil. We should support linux, windows, and consider visionOS as well.

Related comment:
// TODO: Implement for Linux & Windows

Use Case

This info is used as OS metadata in the SDK here

Proposed Solution

No response

Other Information

Related Issue: #710

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dayaffe dayaffe added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 30, 2023
@dayaffe dayaffe mentioned this issue Oct 30, 2023
Closed
2 tasks
@sichanyoo sichanyoo removed the needs-triage This issue or PR still needs to be triaged. label Nov 6, 2023
@sichanyoo sichanyoo added this to the GA milestone Nov 6, 2023
@sichanyoo sichanyoo self-assigned this May 20, 2024
This was referenced May 23, 2024
Merged
Closed
@sichanyoo
Copy link
Contributor

After confirming supported platforms with team, created backlog ticket for Windows portion of this ticket: #1526, to be done if we decide to support Windows down the line.

@sichanyoo sichanyoo changed the title feat: Add linux and windows support in PlatformOperationSystemVersion feat: Add linux support in PlatformOperationSystemVersion May 24, 2024
@sichanyoo sichanyoo changed the title feat: Add linux support in PlatformOperationSystemVersion feat: Add linux and windows support in PlatformOperationSystemVersion May 24, 2024
@sichanyoo
Copy link
Contributor

sichanyoo commented May 24, 2024 •
edited
Loading

Turns out Apple recently implemented getting OS versions for Linux & Windows for us using compiler directives in their Foundation.ProcessInfo. Closing #1526.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sichanyoo sichanyoo

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
GA
Development

No branches or pull requests
2 participants
@dayaffe @sichanyoo