chore: Clean up unnecessary TODOs + move test functions to a better l…

…ocation (#1209)

Tests/Core/AWSClientRuntimeTests/Auth/CredentialsProvidersTests/SSOCredentialsProviderTests.swift

@@ -41,7 +41,4 @@ class SSOCredentialsProviderTests: XCTestCase {
         )
         // SUCCESS: creation didn't throw error
     }
-
-    // TODO: add integration tests that automatically test that SSO crednetials provider correctly exchanges SSO token for temporary AWS credentails.
-    // Manual integration testing confirmed SSOCredentialsProvider works as of 081723.
 }

Tests/Services/AWSS3Tests/EndpointResolverTest.swift

@@ -3428,7 +3428,7 @@ class EndpointResolverTest: XCTestCase {
         }
     }
 
-    /// FIPS + path-only (TODO: consider making this an error)
+    /// FIPS + path-only
     func testResolve123() throws {
         let endpointParams = EndpointParams(
             bucket: "bucket!",

codegen/smithy-aws-swift-codegen/build.gradle.kts

@@ -7,7 +7,6 @@ plugins {
     jacoco
 }
 
-// TODO: remove once we have all the dependencies in the maven-publish plugin
 configurations.implementation {
     exclude(group = "brazil")
 }

codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/PresignerGenerator.kt

@@ -27,8 +27,6 @@ import software.amazon.smithy.swift.codegen.model.expectShape
 data class PresignableOperation(
     val serviceId: String,
     val operationId: String,
-    // TODO ~ Implementation of embedded presigned URLs is TBD
-    // val presignedParameterId: String?
 )
 
 class PresignerGenerator : SwiftIntegration {

codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/customization/InputTypeGETQueryItemMiddleware.kt

@@ -31,7 +31,6 @@ class InputTypeGETQueryItemMiddleware(
 
             val memberTargetShape = ctx.model.expectShape(member.target)
             if (memberTargetShape is IntegerShape || memberTargetShape is TimestampShape) {
-                // TODO: We should support all types in our presignable operations
                 continue
             }
             writer.openBlock("if let $memberName = input.operationInput.$memberName {", "}") {

codegen/smithy-aws-swift-codegen/src/main/kotlin/software/amazon/smithy/aws/swift/codegen/restxml/AWSHttpProtocolRestXMLCustomizations.kt

@@ -16,8 +16,6 @@ class AWSHttpProtocolRestXMLCustomizations : AWSHttpProtocolCustomizations() {
         val properties = mutableListOf<ClientProperty>()
         val requestEncoderOptions = mutableMapOf<String, String>()
         val responseDecoderOptions = mutableMapOf<String, String>()
-        // TODO: Subject to change when we figure out which strategy to use for XML
-        // TODO: Subject to change if Foundation dependency is removed
         requestEncoderOptions["dateEncodingStrategy"] = ".secondsSince1970"
         requestEncoderOptions["nonConformingFloatEncodingStrategy"] = ".convertToString(positiveInfinity: \"Infinity\", negativeInfinity: \"-Infinity\", nan: \"NaN\")"
         responseDecoderOptions["dateDecodingStrategy"] = ".secondsSince1970"

codegen/smithy-aws-swift-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/AWSXAmzTargetMiddlewareTests.kt

@@ -10,18 +10,12 @@ import org.junit.jupiter.api.Test
 import software.amazon.smithy.aws.swift.codegen.awsjson.AwsJson1_0_ProtocolGenerator
 import software.amazon.smithy.aws.swift.codegen.middleware.AWSXAmzTargetMiddleware
 import software.amazon.smithy.aws.traits.auth.UnsignedPayloadTrait
-import software.amazon.smithy.build.MockManifest
-import software.amazon.smithy.codegen.core.SymbolProvider
 import software.amazon.smithy.model.Model
 import software.amazon.smithy.model.shapes.OperationShape
 import software.amazon.smithy.model.shapes.ServiceShape
 import software.amazon.smithy.model.shapes.ShapeId
 import software.amazon.smithy.model.shapes.StructureShape
-import software.amazon.smithy.swift.codegen.SwiftCodegenPlugin
-import software.amazon.smithy.swift.codegen.SwiftDelegator
-import software.amazon.smithy.swift.codegen.SwiftSettings
 import software.amazon.smithy.swift.codegen.SwiftWriter
-import software.amazon.smithy.swift.codegen.integration.ProtocolGenerator
 
 class AWSXAmzTargetMiddlewareTests {
     @Test
@@ -62,33 +56,3 @@ stack.serializeStep.intercept(position: .before, middleware: AWSClientRuntime.XA
         contents.shouldContainOnlyOnce(expectedContents)
     }
 }
-
-// TODO: move to proper location once we figure out where that should be
-fun Model.newTestContext(
-    serviceShapeId: String = "com.test#Example",
-    generator: ProtocolGenerator
-): TestContext {
-    return newTestContext(MockManifest(), serviceShapeId, generator)
-}
-
-fun Model.newTestContext(
-    manifest: MockManifest,
-    serviceShapeId: String,
-    generator: ProtocolGenerator
-): TestContext {
-    val settings = SwiftSettings.from(this, TestContextGenerator.buildDefaultSwiftSettingsObjectNode("com.test#Example"))
-    val provider: SymbolProvider = SwiftCodegenPlugin.createSymbolProvider(this, settings)
-    val service = this.getShape(ShapeId.from(serviceShapeId)).get().asServiceShape().get()
-    val delegator = SwiftDelegator(settings, this, manifest, provider)
-
-    val ctx = ProtocolGenerator.GenerationContext(
-        settings,
-        this,
-        service,
-        provider,
-        listOf(),
-        generator.protocol,
-        delegator
-    )
-    return TestContext(ctx, manifest)
-}

codegen/smithy-aws-swift-codegen/src/test/kotlin/software/amazon/smithy/aws/swift/codegen/TestContextGenerator.kt

@@ -8,6 +8,7 @@ package software.amazon.smithy.aws.swift.codegen
 import org.junit.jupiter.api.Assertions
 import software.amazon.smithy.build.MockManifest
 import software.amazon.smithy.build.PluginContext
+import software.amazon.smithy.codegen.core.SymbolProvider
 import software.amazon.smithy.model.Model
 import software.amazon.smithy.model.node.Node
 import software.amazon.smithy.model.node.ObjectNode
@@ -139,3 +140,32 @@ fun String.toSmithyModel(sourceLocation: String? = null, serviceShapeId: String?
     }
     return model
 }
+
+fun Model.newTestContext(
+    serviceShapeId: String = "com.test#Example",
+    generator: ProtocolGenerator
+): TestContext {
+    return newTestContext(MockManifest(), serviceShapeId, generator)
+}
+
+fun Model.newTestContext(
+    manifest: MockManifest,
+    serviceShapeId: String,
+    generator: ProtocolGenerator
+): TestContext {
+    val settings = SwiftSettings.from(this, TestContextGenerator.buildDefaultSwiftSettingsObjectNode("com.test#Example"))
+    val provider: SymbolProvider = SwiftCodegenPlugin.createSymbolProvider(this, settings)
+    val service = this.getShape(ShapeId.from(serviceShapeId)).get().asServiceShape().get()
+    val delegator = SwiftDelegator(settings, this, manifest, provider)
+
+    val ctx = ProtocolGenerator.GenerationContext(
+        settings,
+        this,
+        service,
+        provider,
+        listOf(),
+        generator.protocol,
+        delegator
+    )
+    return TestContext(ctx, manifest)
+}