misc: gradle mirror #1486
Open
misc: gradle mirror #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view. |
This comment has been minimized.
This comment has been minimized.
ianbotsf
reviewed
Jan 7, 2025
.github/workflows/codebuild-ci.yml
Outdated
Comment on lines
86
to
87
| - name: Configure Gradle | ||
| run: gradle wrapper --gradle-distribution-url ${{ secrets.CUSTOM_GRADLE_DISTRIBUTION_URL }}/gradle-8.5-bin.zip |
There was a problem hiding this comment.
Suggestion: All this repetition means we'll have to update the version number in a bunch of places. This seems like a good candidate for either a custom action or possibly integrating into our common build setup.
There was a problem hiding this comment.
Even better, add the custom action to aws-kotlin-repo-tools like I did for kat
There was a problem hiding this comment.
That would hamper our ability to upgrade Gradle versions independently across the repos. Couldn't that also cause issues that wouldn't be caught until the next run of CI?
There was a problem hiding this comment.
Great suggestion, thanks
There was a problem hiding this comment.
It would be caught when you go to upgrade the version of aws-kotlin-repo-tools you're using
There was a problem hiding this comment.
I think I can turn it into an action with inputs to specify the gradle version we want to use. That way we can move it to repo tools
There was a problem hiding this comment.
Specify the Gradle version where? In each action that uses Gradle? Doesn't that defeat the goal of commonizing the version in a single place?
There was a problem hiding this comment.
Oh you're right, nvm
.github/workflows/codebuild-ci.yml
Outdated
Comment on lines
86
to
87
| - name: Configure Gradle | ||
| run: gradle wrapper --gradle-distribution-url ${{ secrets.CUSTOM_GRADLE_DISTRIBUTION_URL }}/gradle-8.5-bin.zip |
There was a problem hiding this comment.
Question: Why make the distribution URL a secret?
There was a problem hiding this comment.
I think someone could use it and possibly perform some sort of attack. I doubt someone will but theoretically they could take down our CI or just run up our AWS bill
There was a problem hiding this comment.
I think the full command (and the Gradle distribution URL) will still be visible in the CI's logs
There was a problem hiding this comment.
I see it hidden as ***
There was a problem hiding this comment.
Moving conversation offline.
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip |
There was a problem hiding this comment.
Question: Why standardize on 8.5? Why not use the latest release, 8.12?
There was a problem hiding this comment.
Iirc there are some soon to be deprecated features we're using. I'll try using 8.12 and see if everything works okay
There was a problem hiding this comment.
Looks like it works👍
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
Affected ArtifactsSignificantly increased in size
Changed in size
|
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
|
A new generated diff is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.