Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add a section about GraalVM target #1345

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Jul 2, 2024

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner July 2, 2024 16:24
@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jul 2, 2024
Copy link

github-actions bot commented Jul 2, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

This comment has been minimized.

docs/targets.md Outdated
Compiling native images is easily accomplished by applying [the GraalVM build plugin](https://github.com/graalvm/native-build-tools) to your application and running `./gradlew nativeCompile`.
View [their getting started guide](https://graalvm.github.io/native-build-tools/latest/gradle-plugin-quickstart.html) for further details.

NOTE: [log4j2 does not currently support](https://github.com/apache/logging-log4j2/issues/1539) GraalVM native image compilation, so you may need to re-configure your logging.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "so you may need to re-configure your logging" sounds like there's ambiguity or certain factors which may mitigate the problem. I suggest something less open-ended such as "so we recommend selecting a different logger implementation such as logback".

Copy link

sonarqubecloud bot commented Jul 3, 2024

Copy link

github-actions bot commented Jul 3, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

github-actions bot commented Jul 3, 2024

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
drs-jvm.jar closure 10,643,644 10,643,650 -6 -0.00%
ec2-jvm.jar closure 37,009,374 37,010,428 -1,054 -0.00%
ec2-jvm.jar 28,795,375 28,796,428 -1,053 -0.00%
s3-jvm.jar closure 12,801,295 12,802,658 -1,363 -0.01%
s3-jvm.jar 4,500,047 4,501,409 -1,362 -0.03%

@lauzadis lauzadis merged commit de6e8f8 into main Jul 3, 2024
17 checks passed
@lauzadis lauzadis deleted the misc-graalvm-documentation branch July 3, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants