fix: flaky test testAsyncRefreshHandlesFailures
#1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauzadis
added
the
no-changelog
|
|
A new generated diff is ready to view. |
Affected ArtifactsNo artifacts changed size |
0marperez
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and attempts to fix a flaky test
testAsyncRefreshHandlesFailuresby waiting for the s3:CreateSession call to complete before continuing to the assertion. This is wrapped in awithTimeoutblock to prevent hitting an infinite loop.This makes the test more synchronous because it waits for the first async refresh to finish before launching the second. Since the test is only meant to test async refresh being resilient to failures in s3:CreateSession, I think it's fine to make this change.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.