misc: Customize S3's Expires field
#1287
Conversation
lauzadis
changed the title
Expires fieldExpires field
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
note: e2e tests expected to fail until smithy-kotlin is merged and released, they pass locally. |
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
| .asSequence() | ||
| .mapNotNull { shape -> | ||
| shape.members() | ||
| .singleOrNull { member -> member.memberName.lowercase() == "expires" } |
There was a problem hiding this comment.
Nit: Prefer .equals("expires", ignoreCase = true) here and elsewhere
| Instant.fromRfc5322(response.headers["Expires"]!!) | ||
| } catch (e: Exception) { | ||
| coroutineContext.logger<ExpiresFieldInterceptor>().warn { | ||
| "Failed to parse `expires`=${response.headers["Expires"]} as a timestamp, setting it to `null`. The unparsed value is available in `expiresString`." |
There was a problem hiding this comment.
Nit: Include quotes around the value which failed to parse. This makes values which are empty or contain multiple spaces easier to understand.
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
|
A new generated diff is ready to view. |
This PR customizes S3's
Expiresfield to improve the user experience in preparation for upstream model changes.Expiresfields are always timestamps, even if the model changes in the futureExpirestonullif parsing failsFor output shapes only:
ExpiresStringmember which contains the raw string value ofExpiresExpiresin favor ofExpiresStringIssue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.