fix: remove bootstrapAll task from service benchmarks project; move project inclusion logic to root settings.gradle.kts
#1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project inclusion logic to root settings.gradle.kts
ianbotsf
added
the
no-changelog
|
|
A new generated diff is ready to view.
|
lauzadis
approved these changes
Apr 11, 2024
| include(":services:${it.name}") | ||
| } | ||
| } | ||
|
|
||
| // Service benchmarks project | ||
| val benchmarkServices = listOf( | ||
| // keep this list in sync with tests/benchmarks/service-benchmarks/build.gradle.kts |
There was a problem hiding this comment.
I was looking at a way to make this list sharable between settings.gradle.kts and build.gradle.kts, but couldn't find anything. I was hoping the by settings delegated property would work but it doesn't seem to be what we want here. https://docs.gradle.org/current/userguide/kotlin_dsl.html#project_properties
0marperez
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
The
bootstrapAlltask of :tests:benchmarks:service-benchmarks was broken during the refactor of our codegen bootstrapping logic into aws-kotlin-repo-tools. Rather than repair it, this change removes the ability to automatically bootstrap altogether. Instead, now the decision of whether to include the service benchmarks project lies down in settings.gradle.kts. This more closely matches how HLLs will be included/excluded based on bootstrapped service clients.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.