Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update smithy-kotlin repo paths #1269

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore: update smithy-kotlin repo paths #1269

merged 1 commit into from
Apr 1, 2024

Conversation

aajtodd
Copy link
Contributor

@aajtodd aajtodd commented Mar 28, 2024

Issue #

n/a

Description of changes

Update GitHub organization for smithy-kotlin repository.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Mar 28, 2024
@aajtodd aajtodd requested a review from a team as a code owner March 28, 2024 13:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

lauzadis
lauzadis approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@lauzadis lauzadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more references to awslabs/smithy-kotlin in code comments / design docs, are we leaving those as they are?

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@aajtodd
Copy link
Contributor Author

aajtodd commented Mar 28, 2024

There are more references to awslabs/smithy-kotlin in code comments / design docs, are we leaving those as they are?

Yes I don't see a reason to update those. Strictly speaking we don't have to update these either but it is recommended to do so.

@aajtodd aajtodd merged commit 6d05295 into main Apr 1, 2024
18 checks passed
@aajtodd aajtodd deleted the fix-paths branch April 1, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@lauzadis lauzadis lauzadis approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aajtodd @lauzadis @ianbotsf