Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support client-configured accountIdEndpointMode value #1265

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

lauzadis
Copy link
Member

Clients have a configurable accountIdEndpointMode but it's not used anywhere. This came up when testing account ID based endpoints and noticing that accountIdEndpointMode = AccountIdEndpointMode.DISABLED was not having an effect.

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis requested a review from a team as a code owner March 22, 2024 20:51
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@lauzadis lauzadis merged commit da6c9c0 into main Mar 25, 2024
16 checks passed
@lauzadis lauzadis deleted the fix-client-configured-account-id-endpoint-mode branch March 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants