Update smithy to 1.45.0 #1253
Closed
Update smithy to 1.45.0 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also exclude a new protocol test which is failing in the sdk. The test fails because it expects a blob members with a default of "" to have the default populated when a value isn't explicitly provided, but the sdk ignores defaults of "" for blob members. Fixing this is non-trivial because using the default now would change the nullability of members with this default (nullable -> non-nullable). Keeping blobs with "" default nullable but using the default also doesn't work because it means that migrating @required -> @default("") would be a breaking change (granted, it still is now).
|
|
A new generated diff is ready to view.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.