fix: add cloudfront keyvaluestore to sigV4a trait customization #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
|
A new generated diff is ready to view.
|
ianbotsf
approved these changes
Mar 6, 2024
lauzadis
requested changes
Mar 6, 2024
There was a problem hiding this comment.
This trait is already added in BackfillSigV4ACustomization, but to the front of the auth trait list.
We'd need to investigate whether it should be added to the front or back (probably back) and make the appropriate change. But with this change, it will be added to both the front and the back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Added
cloudfront keyvaluestoreto theSigV4AsymmetricTraitCustomizationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.