Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance exception messages with request IDs and metadata #1240

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Mar 1, 2024

Issue #

Closes #1212

Description of changes

This change consumes the latest version of smithy-kotlin to improve construction of ServiceException messages. For S3 exceptions specifically, extended request ID is added to the message.

Companion PR: smithy-lang/smithy-kotlin#1048

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Mar 1, 2024

A new generated diff is ready to view.

@ianbotsf ianbotsf merged commit 9c90cc6 into main Mar 4, 2024
16 of 17 checks passed
@ianbotsf ianbotsf deleted the feat-better-exception-messages branch March 4, 2024 22:55
@ianbotsf ianbotsf restored the feat-better-exception-messages branch March 4, 2024 22:55
ianbotsf added a commit that referenced this pull request Mar 4, 2024
ianbotsf added a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include additional metadata in AwsException by default
3 participants