refactor XML deserialize #1233
Merged
refactor XML deserialize #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Feb 26, 2024
| @@ -90,6 +82,7 @@ class RestXmlParserGenerator( | |||
| else -> super.payloadDeserializer(ctx, shape, members) | |||
| } | |||
|
|
|||
| // FIXME - reconcile | |||
There was a problem hiding this comment.
question: Is this FIXME about explicitBoundStructureSerializer? Do you have a plan to fix in this PR or as a follow-up?
0marperez
reviewed
Feb 27, 2024
| @@ -145,6 +237,7 @@ class RestXmlSerializerGenerator( | |||
| else -> super.payloadSerializer(ctx, shape, members) | |||
| } | |||
|
|
|||
| // FIXME | |||
There was a problem hiding this comment.
nit: there's not context around this FIXME
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Feb 28, 2024
ianbotsf
approved these changes
Feb 28, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
fixes #1220
upstream: smithy-lang/smithy-kotlin#1042
Description of changes
Context is in the linked issue and upstream
smithy-kotlinPRBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.