fix: codebuild ci workflow options #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
ianbotsf
approved these changes
Feb 19, 2024
| shift 2 | ||
| fi | ||
| ;; | ||
| --sdk) |
There was a problem hiding this comment.
Nit: The flag names --sdk and --smithy aren't super clear. I suggest --sdk-pr or something similar.
|
|
A new generated diff is ready to view.
|
lauzadis
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
The script called from the workflow had a bug. If the workflow was not called from a PR then the SDK PR number would be used as a source.
The fix was to label the options, and add logic for empty options. This fixes the bug and should avoid confusion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.