-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: link documentation to fix sigv4a unsupported algorithm #1209
Conversation
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
@@ -23,7 +23,11 @@ public class UnsupportedSigningAlgorithmInterceptor : HttpInterceptor { | |||
context.response.exceptionOrNull()?.let { | |||
if (it is UnsupportedSigningAlgorithmException && it.signingAlgorithm == AwsSigningAlgorithm.SIGV4_ASYMMETRIC) { | |||
return Result.failure( | |||
it, // TODO: Add a message and link pointing to AWS SDK for Kotlin developer guide. | |||
UnsupportedSigningAlgorithmException( | |||
"${it.message} For more information on how to enable it with the CRT signer, please refer to: https://docs.aws.amazon.com/sdk-for-kotlin/latest/developer-guide/use-services-s3-mrap.html#mrap-s3client-config", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ${it.message.ensureSuffix(".")}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, ignore the it.message
and just create your own message from scratch, since you know it will always be this:
SIGV4A support is not yet implemented for the default signer. For more information on how to enable it with the CRT signer, please refer to: https://docs.aws.amazon.com/sdk-for-kotlin/latest/developer-guide/use-services-s3-mrap.html#mrap-s3client-config
A new generated diff is ready to view.
|
A new generated diff is ready to view.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the suggestion by Matas to just ignore the original message and write your own here. Otherwise looks good, fix and ship.
A new generated diff is ready to view.
|
Quality Gate passedIssues Measures |
A new generated diff is ready to view.
|
Issue #
closes #625
Description of changes
Adds a link to exception message on how to fix sigv4a unsupported signing algorithm
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.