Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add Maven Local as build-support repo to enable locally testing changes to Smithy protocol tests #1201

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Feb 5, 2024

Issue #

(none)

Description of changes

New versions of Smithy (e.g., to verify local changes to protocol tests) aren't picked up by the protocol tests task because mavenLocal() is not listed as a repository in the build-support module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Feb 5, 2024
@ianbotsf ianbotsf requested a review from a team as a code owner February 5, 2024 19:15
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

github-actions bot commented Feb 5, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@ianbotsf ianbotsf merged commit 39dbaa2 into main Feb 5, 2024
16 of 17 checks passed
@ianbotsf ianbotsf deleted the misc-reenable-protocol-test-testing branch February 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants