refactor: upstream plugin changes #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
aajtodd
added
the
no-changelog
0marperez
reviewed
Jan 26, 2024
build.gradle.kts
Outdated
| // into the root buildscript classpath and force them to share a class loader. | ||
| classpath(libs.smithy.model) | ||
| classpath(libs.smithy.aws.traits) | ||
| // // FIXME - we need the ClassLoader used for Model and any traits to be the same. Unfortunately our |
There was a problem hiding this comment.
nit: There's double comments here: // //
0marperez
reviewed
Jan 26, 2024
build.gradle.kts
Outdated
| // // that uses both in it's build logic won't work correctly. We "fix" this by placing them both | ||
| // // into the root buildscript classpath and force them to share a class loader. | ||
| // classpath(libs.smithy.model) | ||
| // classpath(libs.smithy.aws.traits) |
There was a problem hiding this comment.
question: Is this meant to be left here?
0marperez
reviewed
Jan 26, 2024
| @@ -8,8 +8,8 @@ import aws.sdk.kotlin.gradle.codegen.smithyKotlinProjectionPath | |||
| import aws.sdk.kotlin.gradle.codegen.smithyKotlinProjectionSrcDir | |||
|
|
|||
| plugins { | |||
| kotlin("jvm") // FIXME - configuration doesn't resolve without this | |||
| id("aws.sdk.kotlin.gradle.smithybuild") | |||
| kotlin("jvm") | |||
There was a problem hiding this comment.
question: Does the FIXME still apply?
There was a problem hiding this comment.
I removed it because there isn't really anything to fix. It was a placeholder but everything works as intended so I don't see the value in keeping it if it's not actionable.
|
|
A new generated diff is ready to view. |
ianbotsf
approved these changes
Jan 26, 2024
0marperez
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
upstream awslabs/aws-kotlin-repo-tools#32
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.