chore: refactor build to use custom smithy build plugin #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
lauzadis
approved these changes
Dec 29, 2023
codegen/sdk/build.gradle.kts
Outdated
| @@ -145,13 +131,14 @@ fun awsServiceProjections(): Provider<List<SmithyProjection>> { | |||
| } | |||
|
|
|||
| // get around class cast issues, listProperty implements what we need to pass this to `NamedObjectContainer` | |||
| return project.objects.listProperty<SmithyProjection>().value(p) | |||
| // return project.objects.listProperty<SmithyProjection>().value(p) | |||
There was a problem hiding this comment.
should this just be removed rather than commented out?
codegen/sdk/build.gradle.kts
Outdated
Comment on lines
184
to
189
| println(software.amazon.smithy.aws.traits.ServiceTrait.ID.toString()) | ||
| println(service.allTraits.map { it.key.toString() }) | ||
| println(service.hasTrait(software.amazon.smithy.aws.traits.ServiceTrait::class.java)) | ||
| println(service.findTrait(software.amazon.smithy.aws.traits.ServiceTrait.ID)) | ||
|
|
||
| println("classloader...") |
There was a problem hiding this comment.
nit: remove unnecessary printlns
settings.gradle.kts
Outdated
| @@ -27,7 +27,7 @@ sourceControl { | |||
|
|
|||
| rootProject.name = "aws-sdk-kotlin" | |||
|
|
|||
| includeBuild("./gradle/sdk-plugins") | |||
| // includeBuild("./gradle/sdk-plugins") | |||
There was a problem hiding this comment.
same comment here, should this just be removed?
0marperez
approved these changes
Dec 29, 2023
|
A new generated diff is ready to view.
|
aajtodd
added
the
no-changelog
|
A new generated diff is ready to view.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Refactors the build to use our new codegen plugin based on the newer smithy gradle base plugin.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.