Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: disable search and address some accessibility violations #1154

Merged
merged 12 commits into from
Dec 15, 2023
Merged

misc: disable search and address some accessibility violations #1154

merged 12 commits into from
Dec 15, 2023

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Dec 15, 2023 •
edited
Loading

  • Disable search due to performance issues (linked tracking issue in code along with FIXME).
  • Address some accessibility violations
    • "Ensure keyboard focus is indicated visually"
    • "Ensure pages reflow without requiring two-dimensional scrolling without loss of content or functionality"
    • "Ensure all interactive functionality is operable with the keyboard"

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@lauzadis lauzadis marked this pull request as ready for review December 15, 2023 19:04
@lauzadis lauzadis requested a review from a team as a code owner December 15, 2023 19:04
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@lauzadis lauzadis merged commit f9d4702 into main Dec 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@0marperez 0marperez 0marperez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lauzadis @0marperez @ianbotsf