Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to gradle 8.5 #1153

Merged
merged 6 commits into from
Dec 19, 2023
Merged

chore: upgrade to gradle 8.5 #1153

merged 6 commits into from
Dec 19, 2023

Conversation

aajtodd
Copy link
Collaborator

@aajtodd aajtodd commented Dec 15, 2023 •
edited
Loading

Issue #

Description of changes

  • Upgrades the build system to Gradle 8.5.
  • Upgrades Kotlin to 1.9.21 bug fix release
  • 1.9.20 requires to specify a -Xexpect-actual-classes flag to suppress warnings about expect/actual classes;
  • upgrade atomic-fu to 0.23.1 and remove explicit dependency on it (plugin adds correct target dependencies depending on plugin settings)

Testing

  • Ran dokka with S3 and verified the API ref docs generate and still link to smithy-kotlin types.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner December 15, 2023 18:17
@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

@aajtodd aajtodd added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Dec 15, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

A new generated diff is ready to view.

@aajtodd aajtodd mentioned this pull request Dec 18, 2023
Closed
@aajtodd aajtodd merged commit a73f757 into main Dec 19, 2023
15 of 16 checks passed
@aajtodd aajtodd deleted the gradle-85 branch December 19, 2023 13:43
@aajtodd aajtodd mentioned this pull request Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@lauzadis lauzadis lauzadis approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aajtodd @lauzadis @ianbotsf