Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to latest version of smithy-kotlin #1149

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

ianbotsf
Copy link
Contributor

@ianbotsf ianbotsf commented Dec 8, 2023

Issue #

Addresses smithy-lang/smithy-kotlin#1008

Description of changes

This change consumes smithy-kotlin 1.0.3 which contains smithy-lang/smithy-kotlin#1010, a fix for URL signing of special characters.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from a team as a code owner December 8, 2023 17:07
@@ -7,7 +7,7 @@ coroutines-version = "1.7.3"
atomicfu-version = "0.22.0"

# smithy-kotlin codegen and runtime are versioned separately
smithy-kotlin-runtime-version = "1.0.2"
smithy-kotlin-runtime-version = "1.0.3"
smithy-kotlin-codegen-version = "0.30.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The latest version of codegen is 0.30.4, should we bump to that to always stay on the latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, probably so.

Copy link

github-actions bot commented Dec 8, 2023

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

sonarqubecloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

github-actions bot commented Dec 8, 2023

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@ianbotsf ianbotsf merged commit da81620 into main Dec 8, 2023
16 of 17 checks passed
@ianbotsf ianbotsf deleted the chore-bump-smithy-kotlin branch December 8, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants