configure dokka to use generated samples #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Dec 6, 2023
ianbotsf
approved these changes
Dec 6, 2023
aajtodd
force-pushed
the
operation-samples
branch
from
a5fe152 to
0819b23
Compare
|
|
A new generated diff is ready to view. |
ianbotsf
approved these changes
Dec 19, 2023
lauzadis
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
closes #239
upstream smithy-lang/smithy-kotlin#1007
Description of changes
This renders using the playground by default which won't actually work, see Kotlin/dokka#3041
We will likely hold off merging this until that is disabled.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.