Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle null partNumber #1125

Merged
merged 2 commits into from
Nov 20, 2023
Merged

fix: Handle null partNumber #1125

merged 2 commits into from
Nov 20, 2023

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Nov 20, 2023

A recent change to the service model for S3 results in partNumber type changing from Int to Int?. Handle that change in our E2E tests to fix the compilation error:

Unresolved reference. None of the following candidates is applicable because of receiver type mismatch:
...
...

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Nov 20, 2023
@lauzadis lauzadis requested a review from a team as a code owner November 20, 2023 20:07
@lauzadis lauzadis changed the title fix: Removed unnecessary .sorted() call fix: Handle null partNumber Nov 20, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

A new generated diff is ready to view.

@lauzadis lauzadis merged commit 939c3f0 into main Nov 20, 2023
16 checks passed
@lauzadis lauzadis deleted the fix-s3-e2e-test branch November 20, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants