Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rt): make region providers public #1123

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

aajtodd
Copy link
Collaborator

@aajtodd aajtodd commented Nov 20, 2023

Issue #

closes #1002
closes #1003

Description of changes

Make RegionProvider implementations public so that they can be composed externally.
Add a constructor that takes an explicit profile name to ProfileRegionProvider

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aajtodd aajtodd requested a review from a team as a code owner November 20, 2023 16:08
Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@aajtodd aajtodd force-pushed the open-region-providers branch from 2bbef45 to 0a2885e Compare November 20, 2023 20:59
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

@aajtodd aajtodd merged commit 094809f into main Nov 20, 2023
16 checks passed
@aajtodd aajtodd deleted the open-region-providers branch November 20, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants