fix: remove CLI only S3 config options #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view. |
lauzadis
requested changes
Oct 18, 2023
| """.trimIndent(), | ||
| ) | ||
|
|
||
| // FUTURE: default signer doesn't yet implement sigv4a, default to mrap OFF until it does |
There was a problem hiding this comment.
Can we keep this comment as a FIXME?
| { | ||
| "id": "5adb30dd-3a4f-4a3c-aa31-e6455785c9c4", | ||
| "type": "misc", | ||
| "description": "**Breaking** Removed `enableAccelerate` & `forcePathStyle` from S3 config" |
There was a problem hiding this comment.
Also added s3_use_arn_region and s3_disable_multiregion_access_points
There was a problem hiding this comment.
Also could mention that we removed the equivalents from AWS profile configuration
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view. |
lauzadis
approved these changes
Oct 19, 2023
aajtodd
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
-Removed
enableAccelerate&forcePathStylefrom S3 config-Moved
useArnRegion&disableMrapshared config source to top level instead of under s3By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.