chore(ci): fix codegen diff #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view. |
|
A new generated diff is ready to view. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view.
|
aajtodd
added
the
no-changelog
lauzadis
approved these changes
Oct 6, 2023
Comment on lines
+54
to
+58
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: 'awslabs/smithy-kotlin' | ||
| fetch-depth: 0 | ||
| path: 'smithy-kotlin' |
There was a problem hiding this comment.
Do we also need aws-crt-kotlin?
There was a problem hiding this comment.
Technically smithy-kotlin could need a branch version of aws-crt-kotlin. However, in this case we mostly care about codegen output so I don't think we care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
fixes #732
upstream support: awslabs/aws-kotlin-repo-tools#16
Description of changes
Removes CRT builder from the equation as it is only good for building at the current HEAD. We need to be able to get dependencies at the correct base ref as well to generate accurate diffs. As such I've added some utility code to repo-tools and refactored the diff preview workflow to use that instead. Now we explicitly checkout our dependencies and rely on our builtin composite build (by having
smithy-kotlina sibling of the sdk directory).This should now correctly handle not only
xyz-branch->mainbut also if you have long running feature branches across repos:and:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.