Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore public visibility on constructor for EcsCredentialsProvider #1049

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

ianbotsf
Copy link
Contributor

Issue #

Fixes #1048

Description of changes

#1042 accidentally removed the public constructor for EcsCredentialsProvider, leaving no way to instantiate it manually. This change promotes the internal constructor to public.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf requested a review from a team as a code owner September 18, 2023 21:56
Copy link
Collaborator

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing e2e tests and service check batch needs looked at before merge but looks good.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ianbotsf ianbotsf merged commit 3042bbc into main Sep 25, 2023
11 of 12 checks passed
@ianbotsf ianbotsf deleted the fix-ecscredprov-constructor branch September 25, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: EcsCredentialsProvider constructor is internal only (#946 / 0.32.2-beta)
3 participants