Skip to content

Commit

Permalink
misc: correct test assertion and @Ignore it (#1239)
Browse files Browse the repository at this point in the history
  • Loading branch information
lauzadis authored Mar 1, 2024
1 parent f7c09f7 commit 95386d3
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions services/s3/e2eTest/src/S3ExpressTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ class S3ExpressTest {
}
}

@Ignore
@Test
fun testPresignedPutObject() = runTest {
val content = "Presign this!"
Expand All @@ -98,11 +99,9 @@ class S3ExpressTest {
5.minutes,
)

assertTrue(presigned.url.parameters.decodedParameters.contains("X-Amz-Security-Token"))

// FIXME Presigned requests should use S3 Express Auth Scheme resulting in `X-Amz-S3session-Token`
// https://github.com/awslabs/aws-sdk-kotlin/issues/1236
assertFalse(presigned.url.parameters.decodedParameters.contains(S3_EXPRESS_SESSION_TOKEN_HEADER))
assertTrue(presigned.url.parameters.decodedParameters.contains(S3_EXPRESS_SESSION_TOKEN_HEADER))
}
}

Expand Down

0 comments on commit 95386d3

Please sign in to comment.