fix: remove InvalidChangeBatch customization (#1435)

awslabs · Oct 11, 2024 · 7f5f09b · 7f5f09b
1 parent 650f7b2
commit 7f5f09b
Show file tree

Hide file tree

Showing 7 changed files with 82 additions and 241 deletions.
diff --git a/.changes/a9deee4f-8f15-472c-906f-492066275178.json b/.changes/a9deee4f-8f15-472c-906f-492066275178.json
@@ -0,0 +1,8 @@
+{
+    "id": "a9deee4f-8f15-472c-906f-492066275178",
+    "type": "bugfix",
+    "description": "Remove Route53 InvalidChangeBatch error response customization",
+    "issues": [
+        "https://github.com/awslabs/aws-sdk-kotlin/issues/1433"
+    ]
+}
diff --git a/.../kotlin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegration.kt b/.../kotlin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegration.kt
diff --git a/...ces/META-INF/services/software.amazon.smithy.kotlin.codegen.integration.KotlinIntegration b/...ces/META-INF/services/software.amazon.smithy.kotlin.codegen.integration.KotlinIntegration
@@ -33,7 +33,6 @@ aws.sdk.kotlin.codegen.customization.glacier.GlacierBodyChecksum
 aws.sdk.kotlin.codegen.customization.polly.PollyPresigner
 aws.sdk.kotlin.codegen.customization.machinelearning.MachineLearningEndpointCustomization
 aws.sdk.kotlin.codegen.customization.route53.TrimResourcePrefix
-aws.sdk.kotlin.codegen.customization.route53.ChangeResourceRecordSetsUnmarshallingIntegration
 aws.sdk.kotlin.codegen.customization.ec2.EC2MakePrimitivesOptional
 aws.sdk.kotlin.codegen.customization.RemoveDefaults
 aws.sdk.kotlin.codegen.customization.s3.UnsupportedSigningAlgorithmIntegration

diff --git a/...lin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegrationTest.kt b/...lin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegrationTest.kt
diff --git a/...mon/src/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshalling.kt b/...mon/src/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshalling.kt
diff --git a/...est/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshallingTest.kt b/...est/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshallingTest.kt
diff --git a/services/route53/e2eTest/src/InvalidChangeBatchTest.kt b/services/route53/e2eTest/src/InvalidChangeBatchTest.kt
@@ -0,0 +1,74 @@
+/*
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+package aws.sdk.kotlin.services.route53
+
+import aws.sdk.kotlin.services.route53.model.*
+import aws.smithy.kotlin.runtime.util.Uuid
+import kotlinx.coroutines.test.runTest
+import kotlin.test.Test
+import kotlin.test.assertFailsWith
+import kotlin.test.assertNotNull
+
+// https://github.com/awslabs/aws-sdk-kotlin/issues/1433
+class InvalidChangeBatchTest {
+    @Test
+    fun testMessageIsPopulated() = runTest {
+        Route53Client {
+            region = "us-east-1"
+        }.use { client ->
+            val createHostedZoneResp = client.createHostedZone {
+                this.callerReference = Uuid.random().toString()
+                this.name = "this-is-a-test-hosted-zone-for-aws-sdk-kotlin.com"
+            }
+
+            val hostedZoneId = checkNotNull(createHostedZoneResp.hostedZone?.id) { "Hosted zone is unexpectedly null" }
+
+            try {
+                val exception = assertFailsWith<InvalidChangeBatch> {
+                    client.changeResourceRecordSets {
+                        this.hostedZoneId = hostedZoneId
+                        this.changeBatch = ChangeBatch {
+                            this.changes = listOf(
+                                Change {
+                                    this.action = ChangeAction.Delete
+                                    this.resourceRecordSet = ResourceRecordSet {
+                                        this.name = "test.blerg.com"
+                                        this.type = RrType.Cname
+                                        this.ttl = 300
+                                        this.resourceRecords = listOf(
+                                            ResourceRecord {
+                                                value = "test.blerg.com"
+                                            },
+                                        )
+                                    }
+                                },
+                                Change {
+                                    this.action = ChangeAction.Create
+                                    this.resourceRecordSet = ResourceRecordSet {
+                                        this.name = "test.blerg.com"
+                                        this.type = RrType.Cname
+                                        this.ttl = 300
+                                        this.resourceRecords = listOf(
+                                            ResourceRecord {
+                                                value = "test.blerg.com"
+                                            },
+                                        )
+                                    }
+                                },
+                            )
+                            this.comment = "testing..."
+                        }
+                    }
+                }
+
+                assertNotNull(exception.message)
+            } finally {
+                client.deleteHostedZone {
+                    id = hostedZoneId
+                }
+            }
+        }
+    }
+}