Try joining job in tests

awslabs · Mar 5, 2024 · 7a8aeb5 · 7a8aeb5
1 parent d50ef6c
commit 7a8aeb5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...s/s3/common/src/aws/sdk/kotlin/services/s3/express/DefaultS3ExpressCredentialsProvider.kt b/...s/s3/common/src/aws/sdk/kotlin/services/s3/express/DefaultS3ExpressCredentialsProvider.kt
@@ -68,7 +68,6 @@ internal class DefaultS3ExpressCredentialsProvider(
     }
 
     override fun close() {
-        runBlocking { coroutineContext.job.join() }
         coroutineContext.cancel(null)
     }
 

diff --git a/...common/test/aws/sdk/kotlin/services/s3/express/DefaultS3ExpressCredentialsProviderTest.kt b/...common/test/aws/sdk/kotlin/services/s3/express/DefaultS3ExpressCredentialsProviderTest.kt
@@ -109,6 +109,7 @@ class DefaultS3ExpressCredentialsProviderTest {
         // allow the async refresh to initiate before closing the provider
         runBlocking { delay(50.milliseconds) }
 
+        provider.coroutineContext.job.join()
         provider.close()
         assertEquals(1, testClient.numCreateSession)
     }
@@ -146,6 +147,7 @@ class DefaultS3ExpressCredentialsProviderTest {
         // allow the async refresh to initiate before closing the provider
         runBlocking { delay(50.milliseconds) }
 
+        provider.coroutineContext.job.join()
         provider.close()
         assertEquals(1, testClient.numCreateSession)
     }
@@ -186,6 +188,7 @@ class DefaultS3ExpressCredentialsProviderTest {
         // allow the async refresh to initiate before closing the provider
         runBlocking { delay(50.milliseconds) }
 
+        provider.coroutineContext.job.join()
         provider.close()
         assertEquals(2, testClient.numCreateSession)
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,7 +68,6 @@ internal class DefaultS3ExpressCredentialsProvider( @@
         }
         override fun close() {
-            runBlocking { coroutineContext.job.join() }
             coroutineContext.cancel(null)
         }
@@ Expand Down @@