Review feedback

awslabs · Dec 5, 2023 · 00e0032 · 00e0032
1 parent 5b2a309
commit 00e0032
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/...untime/aws-config/common/src/aws/sdk/kotlin/runtime/config/AbstractAwsSdkClientFactory.kt b/...untime/aws-config/common/src/aws/sdk/kotlin/runtime/config/AbstractAwsSdkClientFactory.kt
@@ -80,8 +80,8 @@ public abstract class AbstractAwsSdkClientFactory<
             config.useDualStack = config.useDualStack ?: resolveUseDualStack(profile = profile)
             config.applicationId = config.applicationId ?: resolveUserAgentAppId(platform, profile)
             if (config is CompressionClientConfig.Builder) {
-                config.disableRequestCompression = config.disableRequestCompression ?: resolveDisableRequestCompression(platform, profile) ?: false
-                config.requestMinCompressionSizeBytes = config.requestMinCompressionSizeBytes ?: resolveRequestMinCompressionSizeBytes(platform, profile) ?: 10240
+                config.disableRequestCompression = config.disableRequestCompression ?: resolveDisableRequestCompression(platform, profile)
+                config.requestMinCompressionSizeBytes = config.requestMinCompressionSizeBytes ?: resolveRequestMinCompressionSizeBytes(platform, profile)
             }
 
             finalizeConfig(builder, sharedConfig, profile)

diff --git a/.../common/src/aws/sdk/kotlin/runtime/config/compression/ResolveDisableRequestCompression.kt b/.../common/src/aws/sdk/kotlin/runtime/config/compression/ResolveDisableRequestCompression.kt
@@ -14,8 +14,8 @@ import aws.smithy.kotlin.runtime.util.PlatformProvider
 
 /**
  * Attempts to resolve disableRequestCompression from specified sources.
- * @return The disableRequestCompression setting if found, null if not
+ * @return The disableRequestCompression setting if found, the default value if not
  */
 @InternalSdkApi
-public suspend fun resolveDisableRequestCompression(platform: PlatformProvider = PlatformProvider.System, profile: LazyAsyncValue<AwsProfile>): Boolean? =
-    CompressionSettings.AwsDisableRequestCompression.resolve(platform) ?: profile.get().disableRequestCompression
+public suspend fun resolveDisableRequestCompression(platform: PlatformProvider = PlatformProvider.System, profile: LazyAsyncValue<AwsProfile>): Boolean =
+    CompressionSettings.AwsDisableRequestCompression.resolve(platform) ?: profile.get().disableRequestCompression ?: false
diff --git a/...on/src/aws/sdk/kotlin/runtime/config/compression/ResolveRequestMinCompressionSizeBytes.kt b/...on/src/aws/sdk/kotlin/runtime/config/compression/ResolveRequestMinCompressionSizeBytes.kt
@@ -14,8 +14,8 @@ import aws.smithy.kotlin.runtime.util.PlatformProvider
 
 /**
  * Attempts to resolve requestMinCompressionSizeBytes from specified sources.
- * @return The requestMinCompressionSizeBytes setting if found, null if not
+ * @return The requestMinCompressionSizeBytes setting if found, the default value if not
  */
 @InternalSdkApi
-public suspend fun resolveRequestMinCompressionSizeBytes(platform: PlatformProvider = PlatformProvider.System, profile: LazyAsyncValue<AwsProfile>): Long? =
-    CompressionSettings.AwsRequestMinCompressionSizeBytes.resolve(platform) ?: profile.get().requestMinCompressionSizeBytes
+public suspend fun resolveRequestMinCompressionSizeBytes(platform: PlatformProvider = PlatformProvider.System, profile: LazyAsyncValue<AwsProfile>): Long =
+    CompressionSettings.AwsRequestMinCompressionSizeBytes.resolve(platform) ?: profile.get().requestMinCompressionSizeBytes ?: 10240
diff --git a/.../src/main/kotlin/aws/sdk/kotlin/codegen/protocols/core/AwsHttpBindingProtocolGenerator.kt b/.../src/main/kotlin/aws/sdk/kotlin/codegen/protocols/core/AwsHttpBindingProtocolGenerator.kt
@@ -52,10 +52,6 @@ abstract class AwsHttpBindingProtocolGenerator : HttpBindingProtocolGenerator()
     }
 
     override fun generateProtocolUnitTests(ctx: ProtocolGenerator.GenerationContext) {
-        val ignoredTests = TestMemberDelta(
-            setOf(),
-        )
-
         // The following can be used to generate only a specific test by name.
         // val targetedTest = TestMemberDelta(setOf("RestJsonComplexErrorWithNoMessage"), TestContainmentMode.RUN_TESTS)
 
@@ -68,7 +64,6 @@ abstract class AwsHttpBindingProtocolGenerator : HttpBindingProtocolGenerator()
             requestTestBuilder,
             responseTestBuilder,
             errorTestBuilder,
-            ignoredTests,
         ).generateProtocolTests()
     }